Masanari, On Mon, 13 Mar 2017, Masanari Iida wrote:
> Subject : [PATCH] [linux-next] x86/smpboot: Remove duplicate inclusion of > asm/reammode.h The "linux-next" tag is pointless. The duplicate include is in Linus tree as well, so this is not linux-next specific at all. Please be more careful with your subject lines. reammode.h ???? > This patch remove duplicate asm/realmode.h in smpboot.c Please read Documentation/process/submitting-patches.rst. Especially the following paragraph: Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour "This patch" is really pointless. We already know that this is a patch, otherwise you wouldn't have sent it with the "[PATCH]" prefix in the subject line. > Confirm successfully compile after remove the line. That's obvious, isn't it? If the include is duplicate the removal won't break anything. > Signed-off-by: Masanari Iida <[email protected]> > > # Please enter the commit message for your changes. Lines starting > # with '#' will be kept; you may remove them yourself if you want to. > # An empty message aborts the commit. > # On branch smpboot-fix > # Changes to be committed: > # modified: arch/x86/kernel/smpboot.c > # Please adjust your workflow. This is not part of a changelog. It's the comment section of the git-commit template which should not be part of your patch submission at all. Thanks, tglx
