On Tue, 14 Mar 2017, Andy Shevchenko wrote: > On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote: > > On Mon, 13 Mar 2017, Andy Shevchenko wrote: > > > > > Crystal Cove and Whiskey Cove are two different PMICs which are > > > installed on Intel Atom SoC based platforms. > > > > > > Moreover there are two independent drivers that by some reason are > > > supposed (*) to get into one kernel module. > > > > > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never ever tested. The line > > > in > > > Makefile is actually wrong. > > > > config INTEL_SOC_PMIC > > > - bool "Support for Intel Atom SoC PMIC" > > > + bool "Support for Crystal Cove PMIC" > > > depends on GPIOLIB > > > depends on I2C=y > > > select MFD_CORE > > > select REGMAP_I2C > > > select REGMAP_IRQ > > > help > > > - Select this option to enable support for the PMIC device > > > + Select this option to enable support for Crystal Cove > > > PMIC > > > on some Intel SoC systems. The PMIC provides ADC, GPIO, > > > thermal, charger and related power management functions > > > on these systems. > > > > > > +config INTEL_SOC_PMIC_BXTWC > > > + tristate > > > + select MFD_CORE > > > + select REGMAP_IRQ > > > > I think you need to make mention that this is Whiskey Cove? > > It's selectable option, so I don't know if it's a good idea to make it > visible to the user. Or do you mean fill the help section only?
I think you just answered your own question. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
