Using dev_name() as irq name during request_irq() might be misleading in
case of serial over PCI. Therefore use a better alternative name for
identifying serial port irqs as "serial" appended with serial_index of
the port. This ensures that "serial" string is always present in irq
name while port index will help in distinguishing b/w different ports.

Signed-off-by: Vignesh R <[email protected]>
---

Based on top of tty-next.

 drivers/tty/serial/8250/8250_core.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c 
b/drivers/tty/serial/8250/8250_core.c
index f83b69f30987..78bf621d6827 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port 
*up)
 
                ret = 0;
        } else {
+               char *irqname = kmalloc(20, GFP_KERNEL);
+               if (!irqname) {
+                       spin_unlock_irq(&i->lock);
+                       return -ENOMEM;
+               }
+               snprintf(irqname, 20,
+                        "serial%d", serial_index(&up->port));
+
                INIT_LIST_HEAD(&up->list);
                i->head = &up->list;
                spin_unlock_irq(&i->lock);
                irq_flags |= up->port.irqflags;
                ret = request_irq(up->port.irq, serial8250_interrupt,
-                                 irq_flags, dev_name(up->port.dev), i);
+                                 irq_flags, irqname, i);
                if (ret < 0)
                        serial_do_unlink(i, up);
        }
-- 
2.11.0

Reply via email to