On 03/29, Linus Torvalds wrote: > > On Wed, Mar 29, 2017 at 9:55 AM, Oleg Nesterov <o...@redhat.com> wrote: > > > > Once again, it is only used in arch/x86/kernel/signal.c by do_signal() and > > handle_signal(). We do not care if mmap() returns a valid pointer with the > > high bit set, regs-ax can't be confused with -ERESTART code. > > Immaterial. If the function is called "get_error()", it sure as hell > shouldn't return a random non-error value.
Oh, I agree, and let me repeat the 3rd time that I suggest to kill this helper and use syscall_get_return_value() in arch/x86/kernel/signal.c, it has no other callers. Oleg.