On Thu, 2017-03-30 at 09:23 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <[email protected]> wrote:
>
> > Intel Edison has Wi-Fi + BT module attached and, since it's an SFI-
> > enumerated
> > platform, needs a platform data. Here we add bits to enable
> > bluetooth device.
> > +
> > +static struct gpiod_lookup_table tng_bt_sfi_gpio_table = {
> > + .dev_id = "hci_bcm",
> > + .table = {
> > + GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> > GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("0000:00:0c.0", -1, "shutdown",
> > GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("0000:00:0c.0", -1, "host-wakeup",
> > GPIO_ACTIVE_HIGH),
>
> Minor nit: just out of general principle (because the rest of the code
> looks so
> nice) I'd properly tabulate the last column as well - something like:
>
> GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP("0000:00:0c.0", -1,
> "shutdown", GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP("0000:00:0c.0", -1, "host-
> wakeup", GPIO_ACTIVE_HIGH),
>
> Formatted that way the reviewer's eye can skip over those values in
> 100
> milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH.
Thanks for a hint.
Should I resend it?
--
Andy Shevchenko <[email protected]>
Intel Finland Oy
