On Thu, Mar 30, 2017 at 12:54 PM, Ingo Molnar <[email protected]> wrote:
>> > Minor nit: just out of general principle (because the rest of the code
>> > looks so
>> > nice) I'd properly tabulate the last column as well - something like:
>> >
>> > GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
>> > GPIO_ACTIVE_HIGH),
>> > GPIO_LOOKUP("0000:00:0c.0", -1,
>> > "shutdown", GPIO_ACTIVE_HIGH),
>> > GPIO_LOOKUP("0000:00:0c.0", -1, "host-
>> > wakeup", GPIO_ACTIVE_HIGH),
>> >
>> > Formatted that way the reviewer's eye can skip over those values in
>> > 100
>> > milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH.
>>
>> Thanks for a hint.
>> Should I resend it?
>
> Yeah, please send a v2.
Sent and just noticed I forgot to increase version number.
--
With Best Regards,
Andy Shevchenko
