On Mon, 10 Apr 2017, [email protected] wrote: > From: Kuppuswamy Sathyanarayanan <[email protected]> > > Currently all PMIC GPIO domain irqs are consumed by the same > device(bxt_wcove_gpio), so there is no need to export them as > separate interrupts. We can just export only the first level > GPIO irq(BXTWC_GPIO_LVL1_IRQ) as an irq resource and let the > GPIO device driver(bxt_wcove_gpio) handle the GPIO sub domain > irqs based on status value of GPIO level2 interrupt status > register. Also, just using only the first level irq will eliminate > the bug involved in requesting only the second level irq and not > explicitly enable the first level irq. For more info on this > issue please read the details at, > > https://lkml.org/lkml/2017/2/27/148 > > Signed-off-by: Kuppuswamy Sathyanarayanan > <[email protected]> > --- > drivers/mfd/intel_soc_pmic_bxtwc.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-)
For my own reference: Acked-for-MFD-by: Lee Jones <[email protected]> > diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c > b/drivers/mfd/intel_soc_pmic_bxtwc.c > index c08d514..dc8af1d 100644 > --- a/drivers/mfd/intel_soc_pmic_bxtwc.c > +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c > @@ -88,8 +88,6 @@ enum bxtwc_irqs_level2 { > BXTWC_USBC_IRQ, > BXTWC_CHGR0_IRQ, > BXTWC_CHGR1_IRQ, > - BXTWC_GPIO0_IRQ, > - BXTWC_GPIO1_IRQ, > BXTWC_CRIT_IRQ, > }; > > @@ -115,8 +113,6 @@ static const struct regmap_irq bxtwc_regmap_irqs_level2[] > = { > REGMAP_IRQ_REG(BXTWC_USBC_IRQ, 2, BIT(5)), > REGMAP_IRQ_REG(BXTWC_CHGR0_IRQ, 2, 0x1f), > REGMAP_IRQ_REG(BXTWC_CHGR1_IRQ, 3, 0x1f), > - REGMAP_IRQ_REG(BXTWC_GPIO0_IRQ, 4, 0xff), > - REGMAP_IRQ_REG(BXTWC_GPIO1_IRQ, 5, 0x3f), > REGMAP_IRQ_REG(BXTWC_CRIT_IRQ, 6, 0x03), > }; > > @@ -152,8 +148,7 @@ static struct regmap_irq_chip bxtwc_regmap_irq_chip_tmu = > { > }; > > static struct resource gpio_resources[] = { > - DEFINE_RES_IRQ_NAMED(BXTWC_GPIO0_IRQ, "GPIO0"), > - DEFINE_RES_IRQ_NAMED(BXTWC_GPIO1_IRQ, "GPIO1"), > + DEFINE_RES_IRQ_NAMED(BXTWC_GPIO_LVL1_IRQ, "GPIO"), > }; > > static struct resource adc_resources[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
