On Tue, 2 May 2017, Gustavo A. R. Silva wrote: > Remove unnecessary null check. udev->tt cannot ever be NULL when this > section of code runs. > > Addresses-Coverity-ID: 100828 > Cc: Alan Stern <st...@rowland.harvard.edu> > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- > drivers/usb/host/ehci-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index 980a6b3..6bc6304 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1105,7 +1105,7 @@ iso_stream_init( > addr |= epnum << 8; > addr |= dev->devnum; > stream->ps.usecs = HS_USECS_ISO(maxp); > - think_time = dev->tt ? dev->tt->think_time : 0; > + think_time = dev->tt->think_time; > stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time( > dev->speed, is_input, 1, maxp)); > hs_transfers = max(1u, (maxp + 187) / 188);
Acked-by: Alan Stern <st...@rowland.harvard.edu>
