On Fri, May 19, 2017 at 11:12 AM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Thu, May 18, 2017 at 07:38:29PM +0300, Andy Shevchenko wrote: >> On Thu, May 18, 2017 at 5:38 PM, Mika Westerberg >> <mika.westerb...@linux.intel.com> wrote:
>> One nit here. >> Both has quite similar bodies. >> Wouldn't be nice to split out a helper which takes initial offset and >> type as parameters? > > The whole point of this rework was to separate port vs. switch > capability to follow how the hardware is organized instead of having one > more complex function handling everything :) > > Sure, I can merge them back together but IMHO it will be not that > readable anymore. Up to you. I'm fine with either. -- With Best Regards, Andy Shevchenko
