On 2017.05.31 06:22:28 +0000, Chen, Xiaoguang wrote:
> >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj,
> >struct mdev_device *mdev)
> >> vgpu->vdev.mdev = mdev;
> >> mdev_set_drvdata(mdev, vgpu);
> >>
> >> + ret = intel_vgpu_reg_init_opregion(vgpu);
> >> + if (ret) {
> >> + gvt_vgpu_err("create OpRegion failed\n");
> >> + goto out;
> >> + }
> >
> >Still need to handle error path for created vgpu.
> Just checked the code, if initialize the opregion failed we should first
> release vfio/mdev releated work(maybe call intel_vgpu_release function) and
> then destroy the vgpu. Will update in the next version.
> Better to init opregion inside of create vgpu and do proper error handling there too. -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signature.asc
Description: PGP signature
