clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
 drivers/i2c/busses/i2c-at91.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index fabbb9e..2525cd9 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1083,12 +1083,16 @@ static int at91_twi_probe(struct platform_device *pdev)
                dev_err(dev->dev, "no clock defined\n");
                return -ENODEV;
        }
-       clk_prepare_enable(dev->clk);
+       rc = clk_prepare_enable(dev->clk);
+       if (rc)
+               return rc;
 
        if (dev->dev->of_node) {
                rc = at91_twi_configure_dma(dev, phy_addr);
-               if (rc == -EPROBE_DEFER)
+               if (rc == -EPROBE_DEFER) {
+                       clk_disable_unprepare(dev->clk);
                        return rc;
+               }
        }
 
        if (!of_property_read_u32(pdev->dev.of_node, "atmel,fifo-size",
-- 
1.9.1

Reply via email to