On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
Remove duplicate code.

Addresses-Coverity-ID: 1226951
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
  drivers/infiniband/hw/qib/qib_mad.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c 
b/drivers/infiniband/hw/qib/qib_mad.c
index da295e0..c5eaa3c 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct 
ib_device *ibdev,
                ib_dispatch_event(&event);
        }
- ret = subn_get_portinfo(smp, ibdev, port);
-
        /* restore re-reg bit per o14-12.2.1 */
        pip->clientrereg_resv_subnetto |= clientrereg;

Would be nice to see a few more words in the commit message rather than having to go look for Coverity.

Regardless, patch seems fine to me code wise.

Reviewed-by: Dennis Dalessandro <[email protected]>

Reply via email to