mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature.
Also, you should populate the commit log with what are you doing and why is it required. > Signed-off-by: Jeffy Chen <[email protected]> > > --- > > drivers/mfd/cros_ec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index e31ac60..dc6ce90 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) > > cros_ec_acpi_remove_gpe_handler(); > > + if (ec_dev->irq) > + free_irq(ec_dev->irq, ec_dev); > + > return 0; > } > EXPORT_SYMBOL(cros_ec_remove); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
