On Mon, Jun 12, 2017 at 2:03 PM, Christoph Hellwig <[email protected]> wrote: > On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote: >> > So, this reveals two thins: >> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it >> > completely with the latter? >> >> No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and >> NVME_NIDT_EUI64_LEN. > > Yeah, and I'd rather keep the defines for fields defined in the spec > in nvme.h > >> I'm not sure the NVMe NGUID is the same as a GUID (a.k.a little endian >> UUID). Quoting from the spec: > > It's not at all, the field just has a very unfortunate name in the > spec.
Thanks for explanations. So, wrt that Reviewed-by: Andy Shevchenko <[email protected]> -- With Best Regards, Andy Shevchenko
