On 06/13/2017 07:00 AM, Miroslav Benes wrote: > On Thu, 1 Jun 2017, Joe Lawrence wrote: > >> Modify the sample livepatch to demonstrate the shadow variable API. >> >> Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com> >> --- >> samples/livepatch/livepatch-sample.c | 39 >> +++++++++++++++++++++++++++++++++++- >> 1 file changed, 38 insertions(+), 1 deletion(-) > > Would it make sense to make this our second sample module? I think we > should keep one as simple as possible, and illustrate new features in > separate sample modules. > > I'd like to have another one for klp-convert patch set too. > > What do you think? > > Miroslav >
Yeah, adding this as a new sample module is a good idea. I'll split that out in v2. I'm not familiar with klp-convert, so I'll assume that will be handled as its own patch(set). Thanks, -- Joe
