On Wed, Jun 21, 2017 at 10:16 AM, Liviu Dudau <liviu.du...@arm.com> wrote:
> Hi Arnd,
>
> On Tue, Jun 20, 2017 at 10:30:38PM +0200, Arnd Bergmann wrote:
>> The last rework left behind two unused variables:
>>
>> drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update':
>> drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y'
>> [-Wunused-variable]
>> drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x'
>> [-Wunused-variable]
>>
>> This removes them.
>
> Thanks for the patch! Acked-by: Liviu Dudau <liviu.du...@arm.com>
>
> This is starting to get embarrassing :) I'm not sure why I didn't see the
> warnings when
> I did my builds, but I would like to make changes so that in the future I can
> catch
> situations like this. Do you change the flags of the default make
> multi_v7_defconfig?
I mainly do randconfig testing, which catches a lot of bugs that you don't
see in the defconfig build. My general recommendation is to build-test on
ARM allmodconfig and x86 allmodconfig, and to ensure that all new code
gets enabled with CONFIG_COMPILE_TEST in those builds.
> I will apply the patch to the HLDCD tree and send Dave an updated pull
> request.
Ok, thanks!
Arnd
