On Mon, Jun 19, 2017 at 10:39 PM, John Johansen <[email protected]> wrote: > On 06/19/2017 09:56 PM, Stephen Rothwell wrote: >> Hi all, >> >> After merging the kspp tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> security/apparmor/file.c: In function 'aa_path_link': >> security/apparmor/file.c:475:23: error: positional initialization of field >> in 'struct' declared with 'designated_init' attribute >> [-Werror=designated-init] >> struct path link = { new_dir->mnt, new_dentry }; >> ^ >> security/apparmor/file.c:475:23: note: (near initialization for 'link') >> security/apparmor/file.c:475:37: error: positional initialization of field >> in 'struct' declared with 'designated_init' attribute >> [-Werror=designated-init] >> struct path link = { new_dir->mnt, new_dentry }; >> ^ >> security/apparmor/file.c:475:37: note: (near initialization for 'link') >> security/apparmor/file.c:476:25: error: positional initialization of field >> in 'struct' declared with 'designated_init' attribute >> [-Werror=designated-init] >> struct path target = { new_dir->mnt, old_dentry }; >> ^ >> security/apparmor/file.c:476:25: note: (near initialization for 'target') >> security/apparmor/file.c:476:39: error: positional initialization of field >> in 'struct' declared with 'designated_init' attribute >> [-Werror=designated-init] >> struct path target = { new_dir->mnt, old_dentry }; >> ^ >> security/apparmor/file.c:476:39: note: (near initialization for 'target') >> >> Caused by commit >> >> 1a12979f61e4 ("randstruct: Mark various structs for randomization") >> >> interacting with commit >> >> 8014370f1257 ("apparmor: move path_link mediation to using labels") >> >> from the security tree. >> >> I added the following merge fix patch for today: >> >> From: Stephen Rothwell <[email protected]> >> Date: Tue, 20 Jun 2017 14:50:36 +1000 >> Subject: [PATCH] apparmor: put back designators in struct initialisers >> >> Fixes: 8014370f1257 ("apparmor: move path_link mediation to using labels") >> Signed-off-by: Stephen Rothwell <[email protected]> > Acked-by: John Johansen <[email protected]>
Hi James, Just a ping; this needs to get into -next to avoid build errors. Please consider it also: Acked-by: Kees Cook <[email protected]> Thanks! -Kees -- Kees Cook Pixel Security
