On Thu, Jun 29, 2017 at 11:33 PM, Thomas Gleixner <[email protected]> wrote:

> The irq chip callbacks irq_request/release_resources() have absolutely no
> business with masking and unmasking the irq.
>
> The core code unmasks the interrupt after complete setup and masks it
> before invoking irq_release_resources().
>
> The unmask is actually harmful as it happens before the interrupt is
> completely initialized in __setup_irq().
>
> Remove it.
>
> Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as 
> EINTs")
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Tomasz Figa <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Sylwester Nawrocki <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Kukjin Kim <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Linus Walleij <[email protected]>

Does this patch have a dependency on the rest of the series or should
I just apply it as-is?

Yours,
Linus Walleij

Reply via email to