On Fri, Jun 30, 2017 at 12:01 PM, Davidlohr Bueso <[email protected]> wrote: > While going through the driver wake code, I found the > abuse of BUG_ON to be quite disturbing.
These were coded as BUG_ON to ensure they were addressed. They do not get raised in any running environment. Switching to WARN_ON will make it more difficult to determine that a problem has occurred and with a large system, the details of that failure can easily get buried. Those are my objections. In reality, they are extremely rare and we can easily switch these back to BUG_ON() when we are trying out new releases and live with a WARN_ON() for other instances. > Signed-off-by: Davidlohr Bueso <[email protected]> Ackd-by: Robin Holt <[email protected]>
