On Sun, 2017-07-02 at 22:54 +0100, Christos Gkekas wrote:
> Variable mode in method wacom_show_remote_mode() is defined as u8, thus
> statement (mode >= 0) is always true and should be removed, simplifying
> the logic.
[]
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
[]
> @@ -1671,10 +1671,7 @@ static ssize_t wacom_show_remote_mode(struct kobject
> *kobj,
> u8 mode;
>
> mode = wacom->led.groups[index].select;
> - if (mode >= 0 && mode < 3)
> - return snprintf(buf, PAGE_SIZE, "%d\n", mode);
> - else
> - return snprintf(buf, PAGE_SIZE, "%d\n", -1);
> + return snprintf(buf, PAGE_SIZE, "%d\n", mode < 3 ? mode : -1);
It's also hard to imagine that PAGE_SIZE could be less than 4 bytes so
return sprintf(buf, "%d\n", mode < 3 ? mode : -1);
could work too.
