Hi Arnd, On Fri, Jul 21, 2017 at 10:19 PM, Arnd Bergmann <[email protected]> wrote: > The pci-rcar driver is enabled for compile tests, and this has > now shown that the driver cannot build without CONFIG_OF, > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > interrupt mapping when possible":
That commit is for pci-rcar-gen2.c, not pcie-rcar.c. > ../drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init': > ../drivers/pci/host/pcie-rcar.c:856:2: error: implicit declaration of > function 'of_n_addr_cells' [-Werror=implicit-function-declaration] The line number has changed to 1039 during the last 3 years? > parser->pna = of_n_addr_cells(node); > ^ > As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually > supposed to build fine, which we can achieve if we make the > declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF > and provide an empty inline function otherwise, as we do for > a lot of other of interfaces. > > This lets us build the rcar_pci driver again without CONFIG_OF > for build testing. All platforms using this driver select OF, > so this doesn't change anything for the users. > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: [email protected] > Cc: Rob Herring <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: Lucas Stach <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Magnus Damm <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Ben Dooks <[email protected]> > Cc: [email protected] > Cc: [email protected] Apart from that, for the actual change: Acked-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
