Andy Shevchenko <[email protected]> writes:

>> > +                          fill = hex2bin(hc, ip + 1, 2);
>> > +                          if (fill)
>> > +                                  return fill;
>> 
>> This should not use random errno (in this case, it is -1 (EPERM)).
>
> You perhaps missed the side note I put after --- line.
> It reflects this change.

Sure, I missed to read it. But same here, hex2bin() doesn't care FS's
errno, it is what "random errno" I meant (I.e. hex2bin() might change it
to bool or any other errno again).
-- 
OGAWA Hirofumi <[email protected]>

Reply via email to