On 08/02/2017 05:42 PM, Andrew Morton wrote: > On Wed, 2 Aug 2017 15:55:50 -0700 "Luis R. Rodriguez" <[email protected]> > wrote: > >> On Wed, Aug 2, 2017 at 3:43 PM, Andrew Morton <[email protected]> >> wrote: >>> On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodriguez" <[email protected]> >>> wrote: >>> >>>> We had just forgotten to do this. >>>> >>>> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module >>>> loader") >>>> Signed-off-by: Luis R. Rodriguez <[email protected]> >>>> --- >>>> tools/testing/selftests/kmod/kmod.sh | 0 >>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>> mode change 100644 => 100755 tools/testing/selftests/kmod/kmod.sh >>>> >>>> diff --git a/tools/testing/selftests/kmod/kmod.sh >>>> b/tools/testing/selftests/kmod/kmod.sh >>>> old mode 100644 >>>> new mode 100755 >>> >>> This is pretty fragile - I'm not sure that patch/diff are capable of >>> communicating a bare chmod. If someone does a "patch -p1 < patch-4.14" >>> or whatever, this change is likely to get lost. >> >> True if using regular diff, if using git, it will catch it though. > > Yeah. I don't think this change will make it through my > maze-of-scripts. Perhaps Shuah can pick it up.
Thanks Andrew. I will pick this up. > > Also... > > # find tools/testing/selftests -name "*.sh" -a ! -executable > tools/testing/selftests/rcutorture/configs/rcuperf/ver_functions.sh > tools/testing/selftests/rcutorture/configs/lock/ver_functions.sh > tools/testing/selftests/rcutorture/configs/rcu/ver_functions.sh > tools/testing/selftests/rcutorture/bin/functions.sh > tools/testing/selftests/locking/ww_mutex.sh The above aren't an issue. They aren't included in the selftests/Makefile > tools/testing/selftests/kmod/kmod.sh > tools/testing/selftests/sysctl/sysctl.sh Yeah. sysctl needs to be fixed. Thanks for pointing this out. thanks, -- Shuah
