Hi Yoshihiro,

On 08/09/2017 06:44 AM, Yoshihiro Shimoda wrote:
Hi Gustavo,

Thank you for the patch!

I'm glad to help :)

-----Original Message-----
From: Gustavo A. R. Silva
Sent: Wednesday, August 9, 2017 7:35 AM

platform_get_irq() returns an error code, but the renesas_usb3 driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Thank you for the point. I got it.

Also, notice that platform_get_irq() no longer returns 0 on error:

I don't think this explanation needs.
After this is removed,

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>

Thank you
Gustavo A. R. Silva

Best regards,
Yoshihiro Shimoda

Print error message and propagate the return value of platform_get_irq
on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
 drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c 
index e1de8fe..616d053 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device 
        priv = match->data;

        irq = platform_get_irq(pdev, 0);
-       if (irq < 0)
-               return -ENODEV;
+       if (irq < 0) {
+               dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+               return irq;
+       }

        usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL);
        if (!usb3)

To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to