On Sun, Aug 13, 2017 at 7:13 AM, Andy Shevchenko
<[email protected]> wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
>
> While here, update Copyright to reflect this change along with previous
> one for the topic.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
>
> - if (memcmp(block->gblock.guid, &guid_input, 16) == 0) {
> + if (guid_equal((guid_t *)&block->gblock.guid, &guid_input)) {
As discussed in the other email, NAK.
This line should read:
if (uuid_le_equal(...))
or
if (uuid_le_equal_uuid(...))
or similar. Barring that, I think memcmp() is far better than the
obviously-wrong-but-actually-secretly-correct guid_equal().
--Andy
