Kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
---
 drivers/net/ethernet/broadcom/sb1250-mac.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c 
b/drivers/net/ethernet/broadcom/sb1250-mac.c
index 16a0f19..ecdef42 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -1367,15 +1367,11 @@ static int sbmac_initctx(struct sbmac_softc *s)
 
 static void sbdma_uninitctx(struct sbmacdma *d)
 {
-       if (d->sbdma_dscrtable_unaligned) {
-               kfree(d->sbdma_dscrtable_unaligned);
-               d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
-       }
+       kfree(d->sbdma_dscrtable_unaligned);
+       d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
 
-       if (d->sbdma_ctxtable) {
-               kfree(d->sbdma_ctxtable);
-               d->sbdma_ctxtable = NULL;
-       }
+       kfree(d->sbdma_ctxtable);
+       d->sbdma_ctxtable = NULL;
 }
 
 
-- 
2.7.4

Reply via email to