On Thu, 2017-09-14 at 19:52 +0800, Miles Chen wrote: > Current unnamed function definition argument does not include function > pointer cases and it reports something like: > > WARNING: function definition argument 'void' should also have an identifier > name > +unsigned int (*dummy)(void); > > Support function pointers for unnamed function arguments > > Signed-off-by: Miles Chen <[email protected]>
Acked-by: Joe Perches <[email protected]> > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index dd2c262..03eb255 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -5957,7 +5957,7 @@ sub process { > > # check for function declarations that have arguments without identifier > names > if (defined $stat && > - $stat =~ > /^.\s*(?:extern\s+)?$Type\s*$Ident\s*\(\s*([^{]+)\s*\)\s*;/s && > + $stat =~ > /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s > && > $1 ne "void") { > my $args = trim($1); > while ($args =~ > m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {
