On Wed, Oct 11, 2017 at 03:17:32PM +0200, Michal Hocko wrote: >On Sat 07-10-17 03:02:13, Sasha Levin wrote: >> Remove kmemcheck annotations, and calls to kmemcheck from the kernel. > >How did you generate this? I suspect a git grep + sed? Because this >doesn't seem to be correct. I didn't get further than this
I had an (apparently broken) Coccinelle script to remove references to kmemcheck hooks. >> @@ -266,7 +264,6 @@ static inline int dma_map_sg_attrs(struct device *dev, >> struct scatterlist *sg, >> struct scatterlist *s; >> >> for_each_sg(sg, s, nents, i) >> - kmemcheck_mark_initialized(sg_virt(s), s->length); >> BUG_ON(!valid_dma_direction(dir)); >> ents = ops->map_sg(dev, sg, nents, dir, attrs); >> BUG_ON(ents < 0); > >which doesn't really look correct. I appreciate you have split this up >and the resulting code might even be correct I find it quite important >to have such a large changes be reproducible by reviewers because it is >simply impossible to review this manually. Let me send a fix for that, and review this again. Thanks for the review! >-- >Michal Hocko >SUSE Labs -- Thanks, Sasha
