Hi,
On 2017년 10월 19일 13:47, Chanwoo Choi wrote:
> On 2017년 10월 19일 12:25, Raveendra Padasalagi wrote:
>> Add documentation on optional dt attribute "debounce-timeout-ms"
>> in extcon node to capture user specified timeout value for id
>> and vbus gpio detection.
>>
>> Signed-off-by: Raveendra Padasalagi <[email protected]>
>> Reviewed-by: Ray Jui <[email protected]>
>> Reviewed-by: Srinath Mannam <[email protected]>
>> ---
>>
>> Changes in v2:
>> Rename debounce-timeout-ms to input-debounce
>>
>> Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> index dfc14f7..d115900 100644
>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both
>> can be present as well.
>> - id-gpio: gpio for USB ID pin. See gpio binding.
>> - vbus-gpio: gpio for USB VBUS pin.
>>
>> +Optional properties:
>> +- input-debounce: debounce timeout value for id and vbus gpio in
>> microseconds.
>
> The pinctrl-bindings.txt[1] specify the unit of 'input-debounce'.
> The unit is usec instead of 'microsecond'. You need to modify the description
> of unit.
> [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
Sorry. My mistake. I confused the 'nsec' with 'usec'. This patch is right.
Please ignore my comment.
>
>> +
>> Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
>> extcon_usb1 {
>> compatible = "linux,extcon-usb-gpio";
>>
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi <[email protected]>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
