On Wed, Oct 25, 2017 at 3:06 AM, Takashi Iwai <[email protected]> wrote: > On Tue, 24 Oct 2017 22:07:34 +0200, > Kees Cook wrote: >> >> On Tue, Oct 24, 2017 at 12:25 PM, Takashi Iwai <[email protected]> wrote: >> > On Tue, 24 Oct 2017 17:35:21 +0200, >> > Kees Cook wrote: >> >> >> >> In preparation for unconditionally passing the struct timer_list pointer >> >> to >> >> all timer callbacks, switch to using the new timer_setup() and >> >> from_timer() >> >> to pass the timer pointer explicitly. >> >> >> >> Cc: Jaroslav Kysela <[email protected]> >> >> Cc: Takashi Iwai <[email protected]> >> >> Cc: David Howells <[email protected]> >> >> Cc: [email protected] >> >> Signed-off-by: Kees Cook <[email protected]> >> > >> > I'll skip this as sound/oss/* is already disabled in recent kernels in >> > kbuild, and we're going to remove the whole code soon later. >> >> At the end of these conversions, the old init_timer() and >> setup_timer() APIs will be removed, which would break anything still >> trying to use it (obviously). But if sound/oss/* is _already_ >> unbuildable, then sure, this is fine by me to leave out. :) > > I see a few still remaining users of setup_timer() in sound/*. > Do you already have conversion patches? They are all trivial, so I > can cook up in minutes, too.
I haven't sent the trivial ones (since I am expecting to do a treewide mechanical change for those). I can send you the rest as a patch instead, if you want? -Kees -- Kees Cook Pixel Security
