On Wed, 1 Nov 2017, Borislav Petkov wrote:

> On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote:
> > I'm inclined to leave it.  I first wrote it without the long name and
> > then I had to re-read the code to make sure I got the register state
> > right.  The long name serves as documentation that we need rcx and r11
> > to have special contents.  There's only one place that jumps there and
> > it's in the same function.
> 
> Frankly, I'd prefer a sane label name and a good comment over it instead
> of insanely long label name which is not as explanatory as a normal
> english sentence or two.

Comments are always appreciated, but in that code really expressive labels
make it way better to follow and prevent accidental wreckage.

Thanks,

        tglx

Reply via email to