On Thu 2017-11-09 11:40:28, Greg Kroah-Hartman wrote: > On Thu, Nov 09, 2017 at 10:51:48AM +0100, Pavel Machek wrote: > > Hi! > > > > > It's good to have SPDX identifiers in all files to make it easier to > > > audit the kernel tree for correct licenses. > > > > > > Update the drivers/usb/ and include/linux/usb* files with the correct > > > SPDX license identifier based on the license text in the file itself. > > > The SPDX identifier is a legally binding shorthand, which can be used > > > instead of the full boiler plate text. > > > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > > Ombredanne, and Kate Stewart. > > > > > > Cc: Thomas Gleixner <[email protected]> > > > Cc: Kate Stewart <[email protected]> > > > Cc: Philippe Ombredanne <[email protected]> > > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > > --- > > > v2: Use the "standard" format of putting the identifier at the top of > > > the file, and use // for .c and .h files. > > > Removed the files already marked in Linus's tree. > > > > > > Unless someone really complains, I'm going to add this to my tree for > > > 4.15-rc1. > > > > as you said in some other email... this stands out a bit too > > much. > > That is the goal, sorry.
Then it is bad goal.
Automated tools can pick it up whereever it is. No need to grab
attention with poor placing.
> > What about using normal c comments, and put it near the original
> > license text? It is not exactly the most important thing...
> >
> > Or maybe near the MODULE_LICENSE, so the two don't get out of sync?
>
> No, the top of the file is best, thanks.
No, it is not, thanks.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
