On Thu, Nov 16, 2017 at 01:40:05PM +0000, Srinivas Kandagatla wrote:
> On 16/11/17 13:18, Vinod Koul wrote:
> >On Wed, Nov 15, 2017 at 02:10:33PM +0000, srinivas.kandaga...@linaro.org
> >wrote:
> >
> >>+menuconfig SLIMBUS
> >>+ tristate "Slimbus support"
> >>+ help
> >>+ Slimbus is standard interface between System-on-Chip and audio codec,
> >>+ and other peripheral components in typical embedded systems.
> >>+
> >>+ If unsure, choose N.
> >>+
> >>+if SLIMBUS
> >>+
> >>+# SlIMbus controllers
> >
> >Slimbus perhaps?
> >
> slimbus is specified as "SLIMbus" in the mipi specs, so I should probably
> stay with it and make it consistent across the patchset.
Yeah this I though was a first use, so I though this was a typo. I think
Documentation should use the spec term (like SoundWire) and code should pick
anyone and just be consistent on it.
> >>+static int slim_device_match(struct device *dev, struct device_driver *drv)
> >>+{
> >>+ struct slim_device *sbdev = to_slim_device(dev);
> >>+ struct slim_driver *sbdrv = to_slim_driver(drv);
> >>+
> >>+ return slim_match(sbdrv->id_table, sbdev) != NULL;
> >
> >return !!slim_match() ?
I guess you missed this one..
> >>+struct slim_device_id {
> >>+ __u16 manf_id, prod_code;
> >>+ __u8 dev_index, instance;
> >>+
> >>+ /* Data private to the driver */
> >>+ kernel_ulong_t driver_data;
> >
> >As Takashi pointed out in SDW patches, this needs to be aligned.
> >
> Okay, I will make sure that driver_data is aligned.
You may want to look at comments and disucssion on the SoundWire patches
--
~Vinod
