On Sat, Nov 25, 2017 at 07:22:36PM +1100, Tobin C. Harding wrote: > On Sat, Nov 25, 2017 at 08:56:23AM +0100, Greg Kroah-Hartman wrote: > > On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote: > > > There is currently very little documentation in the kernel on maintainer > > > level tasks. In particular there are no documents on creating pull > > > requests to submit to Linus. > > > > > > Quoting Greg Kroah-Hartman on LKML: > > > > > > Anyway, this actually came up at the kernel summit / maintainer > > > meeting a few weeks ago, in that "how do I make a > > > good pull request to Linus" is something we need to document. > > > > > > Here's what I do, and it seems to work well, so maybe we should turn > > > it into the start of the documentation for how to do it. > > > > > > (quote references: kernel summit, Europe 2017) > > > > > > Create a new kernel documentation book 'how to be a maintainer' > > > (suggested by Jonathan Corbet). Add chapters on 'configuring git' and > > > 'creating a pull request'. > > > > > > Most of the content was written by Linus Torvalds and Greg Kroah-Hartman > > > in discussion on LKML. This is stated at the start of one of the > > > chapters and the original email thread is referenced in > > > 'pull-requests.rst'. > > > > > > Signed-off-by: Tobin C. Harding <m...@tobin.cc> > > > --- > > > > You dropped my reviewed-by :( > > Oh, I didn't realize I was able to keep it between versions. I realize > this was a reasonably trivial change but in general how much change is > ok while keeping the reviewed-by? Who's call is it, the original > author, the reviewed-by dev or the maintainer?
Use your judgement, usually for tiny changes it's good to keep it so people don't have to keep reviewing it and adding it again. thanks, greg k-h
