From: Shrikant Maurya <[email protected]> As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872): API's are using GFP_KERNEL to allocate memory which may sleep.
To ensure atomicity such allocations must be avoided in critical sections under spinlock. Fixed by replacing GFP_KERNEL to GFP_ATOMIC. Reported-by: Jia-Ju Bai <[email protected]> Signed-off-by: Shrikant Maurya <[email protected]> Signed-off-by: Suniel Mahesh <[email protected]> Signed-off-by: Raghu Bharadwaj <[email protected]> Signed-off-by: Karthik Tummala <[email protected]> --- Note: - Patch was compile tested and built(ARCH=arm) on linux-next (latest). - No build issues reported. --- drivers/base/power/wakeup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 38559f0..de56952 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -92,11 +92,11 @@ struct wakeup_source *wakeup_source_create(const char *name) { struct wakeup_source *ws; - ws = kmalloc(sizeof(*ws), GFP_KERNEL); + ws = kmalloc(sizeof(*ws), GFP_ATOMIC); if (!ws) return NULL; - wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_KERNEL) : NULL); + wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_ATOMIC) : NULL); return ws; } EXPORT_SYMBOL_GPL(wakeup_source_create); -- 1.9.1
