On Wed, Sep 13, 2017 at 02:08:58AM +0000, Aneesh Kumar K.V wrote: > @@ -2011,6 +2036,8 @@ static void __split_huge_pmd_locked(struct > vm_area_struct *vma, pmd_t *pmd, > if (soft_dirty) > entry = pte_mksoft_dirty(entry); > } > + if (dirty) > + SetPageDirty(page + i); > pte = pte_offset_map(&_pmd, addr); > BUG_ON(!pte_none(*pte)); > set_pte_at(mm, addr, pte, entry);
The patch is fine. But we don't need to set every 4k dirty. We have single dirty bit for whole THP. I'll change this part and sent the patch as part of the series. -- Kirill A. Shutemov
