On Tue, Jan 09, 2018 at 01:59:02PM +0800, hao_zhang wrote:
> Pin function can not be match correctly when SUNXI_PIN describe with
> mutiple variant and same function.
> 
> such as:
> on pinctrl-sun4i-a10.c
> 
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 2),
>               SUNXI_FUNCTION(0x0, "gpio_in"),
>               SUNXI_FUNCTION(0x1, "gpio_out"),
>               SUNXI_FUNCTION_VARIANT(0x2, "pwm",    /* PWM0 */
>                       PINCTRL_SUN4I_A10 |
>                       PINCTRL_SUN7I_A20),
>               SUNXI_FUNCTION_VARIANT(0x3, "pwm",    /* PWM0 */
>                       PINCTRL_SUN8I_R40)),
> 
> it would always match to the first variant function
> (PINCTRL_SUN4I_A10, PINCTRL_SUN7I_A20)
> 
> so we should add variant compare on it.
> 
> Regards
> Hao
> 
> Signed-off-by: hao_zhang <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature

Reply via email to