On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it, you should be able > to do so. Otherwise you enable bunch of functionality, then go back, > see what new options appeared, enable them, go back, see if any more new > options appeared, and so on. > > What exactly prompted this change?
Two things: today when I reviewed Marcus's patch that selected USB, I commented something along that line. But that was based on something that Linus has written at least two times in the past on lkml. >> >> Signed-off-by: Marcus Folkesson <[email protected]> >> --- >> drivers/input/joystick/Kconfig | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig >> index 332c0cc1b2ab..4a199cff8c68 100644 >> --- a/drivers/input/joystick/Kconfig >> +++ b/drivers/input/joystick/Kconfig >> @@ -279,8 +279,7 @@ config JOYSTICK_JOYDUMP >> >> config JOYSTICK_XPAD >> tristate "X-Box gamepad support" >> - depends on USB_ARCH_HAS_HCD >> - select USB >> + depends on USB >> help >> Say Y here if you want to use the X-Box pad with your computer. >> Make sure to say Y to "Joystick support" (CONFIG_INPUT_JOYDEV) >> -- -- ~Randy
