On 02/08/2018 01:25 AM, Vladislav Valtchev wrote: > On Wed, 2018-02-07 at 22:01 +0800, Zamir SUN wrote: >> >> While just a note for this, in Fedora 27: >> >> $ if command -v swig; then echo 1; else echo 0; fi >> /usr/bin/swig >> 1 >> >> Actually this test has the same problem as of `which swig` - When swig >> exists, the var SWIG_DEFINED will not be 1 (as shown above). >> >> I see Vladislav is already on this thread. I hope this can be fixed >> before merging the patch set. >> > > Hi Zamir, > I'm sorry but I'm unable to reproduce the issue on Fedora 27, > after applying my series of patches. > > In my case (fresh install of Fedora27, no customizations): > if command -v swig; then echo 1; else echo 0; fi > works as expected. > > SWIG_DEFINED does not have to be '1' in order the Makefile to work. > Because the check in my branch is: > > ifeq ($(SWIG_DEFINED), 0) > BUILD_PYTHON := report_noswig > NO_PYTHON = 1 > endif > > So there should be no problem. Just to be sure, I've tried to compile > trace-cmd > with my patches first without 'swig' and later with it (on Fedora). > The result was that, in the first case the message 'no swig installed' > was displayed, while in the other case it was not. Or better, a message > saying that 'python-dev' is missing was shown. > [Yes, both swig and python-dev are necessary]. > > After installing also 'python-devel' (in Ubuntu is just '-dev'), the > build system was able to build the rest of the python targets as well. > > > Could you please try by using my fork on GitHub? > https://github.com/vvaltchev/trace-cmd-fork > BRANCH NAME: make8. > > Let me know if you still experience the issue. >
Hi Vladislav, Thanks for the URL. I tried to build from your make8 branch, it works fine. I must made some copy-paste mistake yesterday. Sorry for the noise. Thanks. > Thanks, > Vlad > > > -- Zamir SUN Fedora user GPG : 1D86 6D4A 49CE 4BBD 72CF FCF5 D856 6E11 F2A0 525E
