On 12/02/18 12:34, Steven Rostedt wrote:
> On Mon, 12 Feb 2018 14:40:28 +0100
> Juri Lelli <juri.le...@redhat.com> wrote:
> > + *  - dl_bw (< 100%) is the bandwidth of the system (domain) on each CPU;
> > + *  - dl_total_bw array contains the currently allocated bandwidth on the
> > + *    i-eth CPU.
> The comment for dl_total_bw doesn't make sense. You mean that
> dl_total_bw is the cpu's bandwidth? If so, let's not call it total,
> because that would suggest it's the bandwidth of all CPUs. What about
> dl_cpu_bw?

Huh, I meant to properly fix this (broken already in mainline) comment,
but I only managed to do that (hopefully) in next patch. :/

However, this surely needs to be fixed here. It's tracking the sum of
all tasks' (across CPUs) bandwidth admitted on the system, so that's why
it's called dl_total_bw. Incremented when a task passes sched_setattr()
and decremented when it leaves the system or changes scheduling class.

Does it make a bit more sense? Would you still prefer a different name?


- Juri

Reply via email to