Some other drivers may be waiting for our extcon to show-up (exiting their
probe methods with -EPROBE_DEFER until we show up).

These drivers will typically get the cable state directly after getting
the extcon, this commit changes the int3496 code to process the id-pin
before registering the extcon, so that other drivers see the correct state
right away.

Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver")
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-Add Fixes tag

Changes in v3:
-Fix oops on probe by scheduling the work too early
---
 drivers/extcon/extcon-intel-int3496.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/extcon/extcon-intel-int3496.c 
b/drivers/extcon/extcon-intel-int3496.c
index c8691b5a9cb0..673bb26a9a2a 100644
--- a/drivers/extcon/extcon-intel-int3496.c
+++ b/drivers/extcon/extcon-intel-int3496.c
@@ -131,11 +131,15 @@ static int int3496_probe(struct platform_device *pdev)
        if (IS_ERR(data->gpio_usb_mux))
                dev_info(dev, "can't request USB MUX GPIO\n");
 
-       /* register extcon device */
        data->edev = devm_extcon_dev_allocate(dev, int3496_cable);
        if (IS_ERR(data->edev))
                return -ENOMEM;
 
+       /* process id-pin first so that we start with the right status */
+       queue_delayed_work(system_wq, &data->work, 0);
+       flush_delayed_work(&data->work);
+
+       /* register extcon device */
        ret = devm_extcon_dev_register(dev, data->edev);
        if (ret < 0) {
                dev_err(dev, "can't register extcon device: %d\n", ret);
@@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev)
                return ret;
        }
 
-       /* queue initial processing of id-pin */
-       queue_delayed_work(system_wq, &data->work, 0);
-
        platform_set_drvdata(pdev, data);
 
        return 0;
-- 
2.14.3

Reply via email to