On Fri, Feb 9, 2018 at 2:03 PM, Petr Mladek <pmla...@suse.com> wrote: > On Thu 2018-02-08 17:29:14, Andy Shevchenko wrote: >> On Wed, Feb 7, 2018 at 5:41 PM, Petr Mladek <pmla...@suse.com> wrote: >> > On Wed 2018-02-07 16:11:13, Geert Uytterhoeven wrote: >> >> > To make it clear. I was talking about "%p" format that is handled >> > in the pointer() function in lib/vsprintf.c. The "(null)" makes >> > sense only for the many modifiers that do deference of >> > the pointer, e.g. "%pa", "%pE", "%ph". >> >> JFYI: I have a patch to eliminate those for %pE & %ph. >> >> Google for "lib/vsprintf: Remove useless NULL checks" as a first in >> the series for new extension to print times. > > I am slightly confused. IMHO, it makes sense to printk "(null)" > for %pE and %ph.
Yes, but isn't it done by if (!ptr) check in the very beginning of the pointer() helper? > Or do you just want to avoid the duplicit check in hex_string() > and escaped_string()? And that is as well. > Well, it might be better to discuss this once you send the patch. I can Cc you, though the patch is pretty independent on the series. I can send it separately. -- With Best Regards, Andy Shevchenko