On 14/02/18 16:00, Stanimir Varbanov wrote:
  .../devicetree/bindings/pci/qcom,pcie.txt          |  4 ++++
  drivers/pci/dwc/pcie-qcom.c                        | 24 ++++++++++++++++++++--
  2 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt 
b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
index 3c9d321b3d3b..1fd703bd73e0 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
@@ -189,6 +189,10 @@
        Value type: <phandle>
        Definition: A phandle to the analog power supply for IC which generates
                    reference clock
+- vddpe-3v3-supply:
shouldn't it be vddpe_3v3-supply to be aligned with the other supplies?

I noticed that, I had to do it intentionally
As dt properties should follow - instead of _


+       Usage: optional
+       Value type: <phandle>
+       Definition: A phandle to the PCIe endpoint power supply
- phys:
        Usage: required for apq8084
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 3e89909f8cb9..519a2ae416eb 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -101,13 +101,14 @@ struct qcom_pcie_resources_1_0_0 {
        struct reset_control *core;
        struct regulator *vdda;
  };
-
please keep above blank line.
Will fix it.

+#define QCOM_PCIE_2_3_2_MAX_SUPPLY     2
  struct qcom_pcie_resources_2_3_2 {
        struct clk *aux_clk;
        struct clk *master_clk;
        struct clk *slave_clk;
        struct clk *cfg_clk;

Reply via email to