Tali, On Thu, Feb 15, 2018 at 2:30 PM, Tali Perry <[email protected]> wrote: > --- /dev/null > +++ b/drivers/clk/clk-npcm7xx.c > @@ -0,0 +1,759 @@ > +/* > + * Nuvoton NPCM7xx Clock Generator > + * All the clocks are initialized by the bootloader, so this driver allow > only > + * reading of current settings directly from the hardware. > + * > + * Copyright (C) 2018 Nuvoton Technologies [email protected] > + * > + * SPDX-License-Identifier: GPL-2.0 > + * Released under the GPLv2 only. > + */
Thank you for using the SPDX tags! but this can be streamlined a bit per [1] The correct way would come out as this: (note the tag placement and comment style and the removal of the now redundant unstructured notice) > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Nuvoton NPCM7xx Clock Generator > + * All the clocks are initialized by the bootloader, so this driver allow > only > + * reading of current settings directly from the hardware. > + * > + * Copyright (C) 2018 Nuvoton Technologies [email protected] > + */ And yes you may be surprised by the use of C++ style comment for this... This has been discussed on list and is what Linus prefers. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne
