On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote:
> Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:
> >
> > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct
> > mtd_info
> > *mtd) break;
> > }
> > doc->chips_per_floor = i;
> > - printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
> > + pr_debug("Detected %d chips per floor.\n", i);
> <bike-shedding>
>
> You are aware of the fact that printk(KERN_DEBUG and pr_debug() are
> not
> equivalent?
> Not a big deal, just want to make sure that you understand what you
> are doing.
Actually pr_debug() shouldn't be used here.
We usually don't prefer pr_debug for drivers, instead we use dev_dbg.
But as Boris told me that it will be better to first having changed all
printks to pr_*() macro and then think about dev_*() macros.
> :-)
>
> </bike-shedding>
>
> Thanks,
> //richard
