We need to make sure a new PCIe tunnel is not created in a middle of
previous PCI rescan because otherwise the rescan code might find too
much and fail to reconfigure devices properly. This is important when
native PCIe hotplug is used. In BIOS assisted hotplug there should be no
such issue.

Fixes: f67cf491175a ("thunderbolt: Add support for Internal Connection Manager 
(ICM)")
Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: sta...@vger.kernel.org
---
 drivers/thunderbolt/switch.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index da54ace4dd2f..1cc79785ce42 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -716,6 +716,13 @@ static int tb_switch_set_authorized(struct tb_switch *sw, 
unsigned int val)
        if (sw->authorized)
                goto unlock;
 
+       /*
+        * Make sure there is no PCIe rescan ongoing when a new PCIe
+        * tunnel is created. Otherwise the PCIe rescan code might find
+        * the new tunnel too early.
+        */
+       pci_lock_rescan_remove();
+
        switch (val) {
        /* Approve switch */
        case 1:
@@ -735,6 +742,8 @@ static int tb_switch_set_authorized(struct tb_switch *sw, 
unsigned int val)
                break;
        }
 
+       pci_unlock_rescan_remove();
+
        if (!ret) {
                sw->authorized = val;
                /* Notify status change to the userspace */
-- 
2.16.1

Reply via email to