> On Fri, 2 Mar 2018 16:40:42 +0100, Antoine Tenart wrote: > > > -/* Initialize Tx FIFO's */ > > +/* Initialize Tx FIFO's > > + * The CP110's total tx-fifo size is 19kB. > > + * Use large-size 10kB for fast port but 3kB for others. > > + */ > > Is there a reason to hardcode 10KB for port 0, and 3KB for the other ports ? > Would there be use cases where the user may want different configurations > ? >
Design requirement are 10KB TX FIFO for the 10Gb/sec and 2.5KB for the 2.5Gb/sec. Since only port 0 support 10Gb/sec and ports 1&2 support up to 2.5Gb/sec. I don't see any reason to change this configurations. Also TX FIFO size could be set only during probe. > It's just that it feels very "hardcoded" to enforce specifically those > numbers. > > Also, does it make sense to mention the CP110 here ? Is this 19 KB limitation > a limit of the PPv2.2 IP, or of the CP110 ? PPv2.2 IP is part of 110 communication processor. Next communication processor will has different Packet processor or next generation of PPv2.x Limit is PPv2.2 TX FIFO. Stefan.
