On Mon, Mar 5, 2018 at 10:42 AM, Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: >> In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value >> which we use to calculate where in our 'nfit_buf' we will place our next >> structure. The handling of 'offset' and the calculation of the placement >> of the next structure is a bit inconsistent, though. We don't update >> 'offset' after we insert each structure, sometimes causing us to update it >> for multiple structures' sizes at once. When calculating the position of >> the next structure we aren't always able to just use 'offset', but >> sometimes have to add in other structure sizes as well. >> >> Fix this by updating 'offset' after each structure insertion in a >> consistent way, allowing us to always calculate the position of the next >> structure to be inserted by just using 'nfit_buf + offset'. >> >> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> > > Ping on this series.
All of these look good to me, applied.