Hi Rob,

Thanks for the review,

> -----Original Message-----
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: Monday, March 05, 2018 2:33 PM
> To: Jolly Shah <jol...@xilinx.com>
> Cc: matthias....@gmail.com; andy.gr...@linaro.org; shawn...@kernel.org;
> geert+rene...@glider.be; bjorn.anders...@linaro.org;
> sean.w...@mediatek.com; m.szyprow...@samsung.com;
> michal.si...@xilinx.com; mark.rutl...@arm.com; Rajan Vaja
> <raj...@xilinx.com>; devicet...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Jolly Shah
> <jol...@xilinx.com>
> Subject: Re: [PATCH 1/2] dt-bindings: soc: Add ZynqMP PM bindings
> 
> On Tue, Feb 27, 2018 at 03:24:25PM -0800, Jolly Shah wrote:
> > Add documentation to describe Xilinx ZynqMP power management bindings.
> >
> > Signed-off-by: Jolly Shah <jol...@xilinx.com>
> > Signed-off-by: Rajan Vaja <raj...@xilinx.com>
> > ---
> >  .../bindings/soc/xilinx/xlnx,zynqmp-power.txt      | 28
> ++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
> > b/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
> > new file mode 100644
> > index 0000000..5b7d963
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.t
> > +++ xt
> > @@ -0,0 +1,28 @@
> > +Xilinx Zynq MPSoC Power Management Device Tree Bindings
> > +
> > +The zynqmp-power node describes the power management configurations.
> 
> That really tells me nothing. What aspect of power management does this
> interface control?
> 

It controls remote suspend/shutdown interfaces. Will add details in next 
version.

> > +
> > +Required properties:
> > + - compatible      : Must contain:  "xlnx,zynqmp-power"
> > + - mbox-names      : Name given to channels seen in the 'mboxes' property.
> > +             "rx" - Mailbox corresponding to receive path
> > +             "tx" - Mailbox corresponding to transmit path
> > + - mboxes  : Standard property to specify a Mailbox. Each value of
> > +             the mboxes property should contain a phandle to the
> > +             mailbox controller device node and an args specifier
> > +             that will be the phandle to the intended sub-mailbox
> > +             child node to be used for communication. See
> > +             Documentation/devicetree/bindings/mailbox/mailbox.txt
> > +             for more details about the generic mailbox controller
> > +             and client driver bindings. Also see
> > +             Documentation/devicetree/bindings/mailbox/ \
> > +             xlnx,zynqmp-ipi-mailbox.txt for typical controller that
> > +             is used to communicate with this System controllers.
> 
> No need to define a standard property here. Just need to say how many entries
> and refer to the common binding.
> 

Ok. Will update same in next version.

> > +
> > +Examples:
> > +   zynqmp_power: zynqmp-power {
> > +           compatible = "xlnx,zynqmp-power";
> > +           mboxes = <&ipi_mailbox_pmu0 0>,
> > +                    <&ipi_mailbox_pmu0 1>;
> > +           mbox-names = "tx", "rx";
> > +   };
> > --
> > 2.7.4
> >

Reply via email to