On Mon, Mar 12, 2018 at 10:06 AM, Kees Cook <keesc...@google.com> wrote: > > I was curious, after the last week of discussion, what you thought of > the future of Alexander's port of the STACKLEAK plugin. Given that > there is progress being made (by at least 8 people at last count) to > actually remove VLAs (and bogus warnings), and that there appears > to be consensus on the approach for how to deal with uninitialized > stack variables, this still leaves an aspect of STACKLEAK unaddressed, > which is reducing the lifetime of stack content validity.
Honestly, I consider that to be one of those crazy patches that people can apply if they want to, but that there is no point in having upstream. Hundreds of extra lines of assembly for something that isn't even a leak or a theoretical fix, when there is a better model for just improving the compiler? Yeah, no. The fact is, people can do their own thing. But for it to make sense _mainline_, it has to improve kernel development, and I don't see it doing that. I just haven't seen an argument for why it makes sense to do the belt-and-suspenders-and-glue-your-pants-on approach. Linus